[
https://issues.apache.org/jira/browse/SQOOP-2544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876427#comment-14876427
]
Sqoop QA bot commented on SQOOP-2544:
-------------------------------------
Testing file
[SQOOP-2544.patch|https://issues.apache.org/jira/secure/attachment/12761183/SQOOP-2544.patch]
against branch sqoop2 took 0:52:31.270276.
{color:red}Overall:{color} -1 due to an error(s), see details below:
{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:red}ERROR:{color} Patch does not add/modify any test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed (executed 1420 tests)
{color:orange}WARNING:{color} Test coverage has decreased
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1702/artifact/patch-process/cobertura_report.txt])
* Package {{execution/mapreduce}}: Can't compare test coverage as base is
missing.
* Package {{common-test}}: Can't compare test coverage as base is missing.
* Package {{common}}: Can't compare test coverage as base is missing.
* Package {{connector/connector-hdfs}}: Can't compare test coverage as base is
missing.
* Package {{connector/connector-ftp}}: Can't compare test coverage as base is
missing.
* Package {{connector/connector-generic-jdbc}}: Can't compare test coverage as
base is missing.
* Package {{connector/connector-sftp}}: Can't compare test coverage as base is
missing.
* Package {{connector/connector-sdk}}: Can't compare test coverage as base is
missing.
* Package {{connector/connector-kafka}}: Can't compare test coverage as base is
missing.
* Package {{connector/connector-kite}}: Can't compare test coverage as base is
missing.
* Package {{server}}: Can't compare test coverage as base is missing.
* Package {{security}}: Can't compare test coverage as base is missing.
* Package {{submission/mapreduce}}: Can't compare test coverage as base is
missing.
* Package {{repository/repository-postgresql}}: Can't compare test coverage as
base is missing.
* Package {{repository/repository-mysql}}: Can't compare test coverage as base
is missing.
* Package {{repository/repository-common}}: Can't compare test coverage as base
is missing.
* Package {{repository/repository-derby}}: Can't compare test coverage as base
is missing.
* Package {{shell}}: Can't compare test coverage as base is missing.
* Package {{client}}: Can't compare test coverage as base is missing.
* Package {{core}}: Can't compare test coverage as base is missing.
* Package {{tomcat}}: Can't compare test coverage as base is missing.
* Package {{test}}: Can't compare test coverage as base is missing.
* Package {{tools}}: Can't compare test coverage as base is missing.
{color:orange}WARNING:{color} New findbugs warnings
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1702/artifact/patch-process/findbugs_report.txt])
* Package {{execution/mapreduce}}: Can't compare classes as base is missing.
* Package {{common-test}}: Can't compare classes as base is missing.
* Package {{common}}: Can't compare classes as base is missing.
* Package {{connector/connector-hdfs}}: Can't compare classes as base is
missing.
* Package {{connector/connector-ftp}}: Can't compare classes as base is missing.
* Package {{connector/connector-generic-jdbc}}: Can't compare classes as base
is missing.
* Package {{connector/connector-sftp}}: Can't compare classes as base is
missing.
* Package {{connector/connector-sdk}}: Can't compare classes as base is missing.
* Package {{connector/connector-kafka}}: Can't compare classes as base is
missing.
* Package {{connector/connector-kite}}: Can't compare classes as base is
missing.
* Package {{server}}: Can't compare classes as base is missing.
* Package {{security}}: Can't compare classes as base is missing.
* Package {{submission/mapreduce}}: Can't compare classes as base is missing.
* Package {{repository/repository-postgresql}}: Can't compare classes as base
is missing.
* Package {{repository/repository-mysql}}: Can't compare classes as base is
missing.
* Package {{repository/repository-common}}: Can't compare classes as base is
missing.
* Package {{repository/repository-derby}}: Can't compare classes as base is
missing.
* Package {{shell}}: Can't compare classes as base is missing.
* Package {{client}}: Can't compare classes as base is missing.
* Package {{core}}: Can't compare classes as base is missing.
* Package {{tomcat}}: Can't compare classes as base is missing.
* Package {{test}}: Can't compare classes as base is missing.
* Package {{tools}}: Can't compare classes as base is missing.
{color:red}ERROR:{color} Some of integration tests failed
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1702/artifact/patch-process/test_integration.txt],
executed 77 tests)
* Test {{new-integration-tests}}
* Test {{org.apache.sqoop.integration.server.InvalidRESTCallsTest}}
Console output is available
[here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1702/console].
This message is automatically generated.
> Sqoop2: Drop connectors servlet
> -------------------------------
>
> Key: SQOOP-2544
> URL: https://issues.apache.org/jira/browse/SQOOP-2544
> Project: Sqoop
> Issue Type: Sub-task
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Fix For: 1.99.7
>
> Attachments: SQOOP-2544.patch, SQOOP-2544.patch
>
>
> If I'm looking correctly, then we have two servlets - one called
> {{Connectors}} and second called {{Connector}} (plurality is the difference).
> Looking into the client code it seems that we're not really using
> {{Connectors}} form anywhere as it's a functionality equivalent for calling
> {{connector/all}}. Hence I would like to propose simply dropping it and have
> one public interface less to worry about. Any objections?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
