----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38589/#review100481 -----------------------------------------------------------
dist/src/main/bin/sqoop.sh (lines 28 - 31) <https://reviews.apache.org/r/38589/#comment157687> I believe that with Hadoop 2 and various distributions such as BigTop, it's very likely that users will end up with different file structure then one single HADOOP_HOME. Hence I have few suggestions: 1) Instead of using "our" own *_LIB directories, what about using *_HOME that are actualy referenced in the documentation (HADOOP_YARN_HOME for example): http://hadoop.apache.org/docs/r2.7.1/hadoop-project-dist/hadoop-common/ClusterSetup.html 2) Rather then re-defining those properties from HADOOP_HOME, can we allow user to keep the original content if it exists. There is a bash expression for that, for example: CATALINA_BIN=${CATALINA_BIN:-${BASEDIR}/server/bin} Will either re-use the CATALINA_BIN if it was defined or use a "default" value of $BASEDIR/server/bin. E.g. user can set all those various locations for our dependencies and we are not insisting on the "right" directory structure. Jarcec - Jarek Cecho On Sept. 22, 2015, 1:30 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38589/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2015, 1:30 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Update script for Jetty server > > > Diffs > ----- > > dist/src/main/bin/sqoop-sys.sh 64dd0bf > dist/src/main/bin/sqoop.sh 707c3fc > > Diff: https://reviews.apache.org/r/38589/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
