> On Sept. 24, 2015, 10:17 p.m., Jarek Cecho wrote:
> > dist/src/main/bin/sqoop.sh, lines 28-31
> > <https://reviews.apache.org/r/38589/diff/1/?file=1079624#file1079624line28>
> >
> > I believe that with Hadoop 2 and various distributions such as BigTop,
> > it's very likely that users will end up with different file structure then
> > one single HADOOP_HOME. Hence I have few suggestions:
> >
> > 1) Instead of using "our" own *_LIB directories, what about using
> > *_HOME that are actualy referenced in the documentation (HADOOP_YARN_HOME
> > for example):
> >
> >
> > http://hadoop.apache.org/docs/r2.7.1/hadoop-project-dist/hadoop-common/ClusterSetup.html
> >
> > 2) Rather then re-defining those properties from HADOOP_HOME, can we
> > allow user to keep the original content if it exists. There is a bash
> > expression for that, for example:
> >
> > CATALINA_BIN=${CATALINA_BIN:-${BASEDIR}/server/bin}
> >
> > Will either re-use the CATALINA_BIN if it was defined or use a
> > "default" value of $BASEDIR/server/bin. E.g. user can set all those various
> > locations for our dependencies and we are not insisting on the "right"
> > directory structure.
> >
> > Jarcec
Thanks for the comments.
I update the patch and do the following changes:
1. remove the check for HADOOP_HOME, if user has the classpath problem when
start the server, he can check the sqoop's document.
2. Update the environment variables from *_LIB* to *_HOME*, and supposed the
necessary will be located in, eg, HADOOP_COMMON_HOME/*.jar,
HADOOP_COMMON_HOME/*.jar.
3. For the environment variables, allow user to keep the original content if it
exists. If no exist, the value will be, eg, ${HADOOP_HOME}/share/hadoop/common.
4. Add external jar for HIVE_HOME and exclude the jdbc jar for derby to avoid
the sealing violation exception.
For the detail, please check the new patch, thanks.
- Colin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38589/#review100481
-----------------------------------------------------------
On Sept. 25, 2015, 7:10 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38589/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2015, 7:10 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Update script for Jetty server
>
>
> Diffs
> -----
>
> dist/src/main/bin/sqoop-sys.sh 64dd0bf
> dist/src/main/bin/sqoop.sh 707c3fc
>
> Diff: https://reviews.apache.org/r/38589/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
