----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38589/#review100960 -----------------------------------------------------------
dist/src/main/bin/sqoop.sh (lines 29 - 33) <https://reviews.apache.org/r/38589/#comment158248> Wouldn't it make more sense to make this check after we define the variables as we're setting up defaults there? Also rather then verifying that those variables are non empty, would it make sense to verify that those variables describes valid directories (e.g. -d instead of -n). - Jarek Cecho On Sept. 29, 2015, 8:18 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38589/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2015, 8:18 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Update script for Jetty server > > > Diffs > ----- > > dist/src/main/bin/sqoop-sys.sh 64dd0bf > dist/src/main/bin/sqoop.sh 707c3fc > > Diff: https://reviews.apache.org/r/38589/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
