> On 五月 17, 2017, 11:50 a.m., Attila Szabo wrote: > > src/java/org/apache/sqoop/manager/Db2Manager.java > > Lines 90-94 (patched) > > <https://reviews.apache.org/r/58600/diff/1/?file=1696010#file1696010line90> > > > > Please fix indentation + formatting here!
Hi Attila Thanks a lot for your detail suggestions Angela > On 五月 17, 2017, 11:50 a.m., Attila Szabo wrote: > > src/java/org/apache/sqoop/manager/Db2Manager.java > > Lines 181 (patched) > > <https://reviews.apache.org/r/58600/diff/1/?file=1696010#file1696010line181> > > > > Is this commit call neded here? > > We've just only executed SELECT statement. What kind of changes we'd > > like to commit? Hi Attila Thanks for your suggestion, I have remove this commit and rollback code for "SELECT" statement Angela > On 五月 17, 2017, 11:50 a.m., Attila Szabo wrote: > > src/java/org/apache/sqoop/manager/Db2Manager.java > > Lines 372-394 (patched) > > <https://reviews.apache.org/r/58600/diff/1/?file=1696010#file1696010line372> > > > > Could you please check if this has been already solved in other > > connectors? > > > > Getting schema option sounds quite general, might have been implemented > > elsewhere in the codebase. > > > > Would make sense to abstract it out, and just call it from different > > places. > > > > Thanks for checking! Hi Attila Yes, this has been already solved in Postgresql. Which file is suitable to abstrace it out? - Ying ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58600/#review175233 ----------------------------------------------------------- On 五月 24, 2017, 9:20 a.m., Ying Cao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58600/ > ----------------------------------------------------------- > > (Updated 五月 24, 2017, 9:20 a.m.) > > > Review request for Sqoop, Abraham Elmahrek, Boglarka Egyed, Jarek Cecho, > Attila Szabo, and Szabolcs Vasas. > > > Bugs: SQOOP-1905 > https://issues.apache.org/jira/browse/SQOOP-1905 > > > Repository: sqoop-trunk > > > Description > ------- > > SQOOP-1905 : add --schema option for import-all-tables and list-tables > against db2 > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/Db2Manager.java 52ab05ef > src/test/org/apache/sqoop/manager/db2/DB2ImportAllTableWithSchema.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/58600/diff/2/ > > > Testing > ------- > > Mannual UT is passed > > > Thanks, > > Ying Cao > >
