> On May 24, 2017, 3:15 p.m., Boglarka Egyed wrote: > > Hi Ying, > > > > I tried to run 'ant clean test' with your patch but ran into some > > compilation errors. Please find the details below. > > > > Thanks, > > Bogi
Hey Bogi, Thanks for checking, and catching these issues! Angela! Please also fix the issues what Bogi raised, and around the logging you could also consider to do some generalization (as I can see you're using LoggingUtils and the Logger itself in a kinda mixed way, depending you your personal preferences it would be nice, to use only one of these ways for logging). Thanks, Attila - Attila ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58600/#review175936 ----------------------------------------------------------- On May 24, 2017, 9:20 a.m., Ying Cao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58600/ > ----------------------------------------------------------- > > (Updated May 24, 2017, 9:20 a.m.) > > > Review request for Sqoop, Abraham Elmahrek, Boglarka Egyed, Jarek Cecho, > Attila Szabo, and Szabolcs Vasas. > > > Bugs: SQOOP-1905 > https://issues.apache.org/jira/browse/SQOOP-1905 > > > Repository: sqoop-trunk > > > Description > ------- > > SQOOP-1905 : add --schema option for import-all-tables and list-tables > against db2 > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/Db2Manager.java 52ab05ef > src/test/org/apache/sqoop/manager/db2/DB2ImportAllTableWithSchema.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/58600/diff/2/ > > > Testing > ------- > > Mannual UT is passed > > > Thanks, > > Ying Cao > >
