> On 六月 5, 2017, 11:09 a.m., Boglarka Egyed wrote: > > src/test/org/apache/sqoop/manager/db2/DB2ImportAllTableWithSchemaManual.java > > Lines 76 (patched) > > <https://reviews.apache.org/r/58600/diff/3/?file=1741029#file1741029line76> > > > > Please use ManualTest at the end so that the related ant task for > > manual tests will find it.
Hi Bogi, Thanks for your remind, I have update fix, please help review it again. Regards, Angela - Ying ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58600/#review176905 ----------------------------------------------------------- On 六月 5, 2017, 3:01 p.m., Ying Cao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58600/ > ----------------------------------------------------------- > > (Updated 六月 5, 2017, 3:01 p.m.) > > > Review request for Sqoop, Abraham Elmahrek, Boglarka Egyed, Jarek Cecho, > Attila Szabo, and Szabolcs Vasas. > > > Bugs: SQOOP-1905 > https://issues.apache.org/jira/browse/SQOOP-1905 > > > Repository: sqoop-trunk > > > Description > ------- > > SQOOP-1905 : add --schema option for import-all-tables and list-tables > against db2 > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/Db2Manager.java 52ab05ef > src/java/org/apache/sqoop/manager/GenericJdbcManager.java 2113a5f5 > > src/test/org/apache/sqoop/manager/db2/DB2ImportAllTableWithSchemaManualTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/58600/diff/4/ > > > Testing > ------- > > Mannual UT is passed > > > Thanks, > > Ying Cao > >
