[
https://issues.apache.org/jira/browse/STORM-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14172482#comment-14172482
]
Robert Joseph Evans commented on STORM-528:
-------------------------------------------
In the past this was fixed by using a symlink to point to the original file,
but that resulted in issues for windows users, where symlinks are not easily
supported. I would ultimately like to see three new jars created. One each
for storm.py, storm.rb, and storm.js. The jars would be very simple and just
have a single file in them.
{code}
/resources/storm.XX
{code}
This allows a topology jar to declare a dependency in their pom.xml like
{code}
<dependency>
<groupId>org.apache.storm</groupId>
<artifactId>storm_py</artifactId>
<version>${storm.version}</version>
</dependency>
{code}
storm-starter would then be updated to use these dependencies.
I would prefer to see the testing of each of these moved over into the same
pom.xml that creates the jar file, just because it would follow the convention
better. This is a bit of a chicken/egg problem because there are some tests
that not only test storm.py, but also test the ShellBolt/ShellSpout code.
Personally I would like to see ShellBolt and ShellSpout tested with true unit
tests that don't rely on storm.py being there, but because we release
everything together I am OK with just relying on the integration tests in the
other three jars for now.
> examples/storm-starter/multilang/resources/storm.py diverged
> ------------------------------------------------------------
>
> Key: STORM-528
> URL: https://issues.apache.org/jira/browse/STORM-528
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.9.2-incubating
> Reporter: Itai Frenkel
>
> As we know storm.py is committed three times. One of these files (the one in
> examples) have diverged from the other two. It also introduces some strange
> behavior as it calls "log" instead of "error" when a bolt fails.
> I would recommend to override the storm/examples version with the one in
> storm-core and then have the diff as a new pull request
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
