Github user HeartSaVioR commented on the pull request:

    https://github.com/apache/storm/pull/268#issuecomment-59529389
  
    I have a question (maybe comment) about your PR.
    (Since I don't know Storm deeply, so it could be wrong. Please correct me 
if I'm wrong!)
    
    When we enqueue tuples to Client, queued tuples seems to be discarded when 
one worker is down and nimbus reassigns task to other worker, and finally 
worker changes task-socket relation.
    But if we enqueue tuples to Drainer, queued tuples may could be sent to new 
worker when task - socket cache is changed to new.
    If I'm right, it would be better to place flusher into TransferDrainer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to