Github user clockfly commented on a diff in the pull request:
https://github.com/apache/storm/pull/268#discussion_r19065812
--- Diff: storm-core/src/clj/backtype/storm/daemon/worker.clj ---
@@ -330,6 +330,20 @@
(.send drainer node+port->socket)))
(.clear drainer))))))
+;; Check whether this messaging connection is ready to send data
+(defn is-connection-ready [^IConnection connection]
+ (if (instance? ConnectionWithStatus connection)
--- End diff --
Here we have a type check (instance?), which may not be clean.
To change IConnection may be cleaner, but that may bring compatible
issues(support the user already implemented some messaging with current
IConnection declaration)
If the messaging connection has extended ConnectionWithStatus, then we will
check the status.
If the messaging connection has NOT extended ConnectionWithStatus, then we
behavior in the same as before. (We will skip this check)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
