[
https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257325#comment-14257325
]
ASF GitHub Bot commented on STORM-243:
--------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/294#discussion_r22228158
--- Diff: storm-core/src/clj/backtype/storm/ui/core.clj ---
@@ -52,15 +52,9 @@
(map #(.get_stats ^ExecutorSummary %))
(filter not-nil?)))
-(defn read-storm-version
+(def read-storm-version
"Returns a string containing the Storm version or 'Unknown'."
- []
- (let [storm-home (System/getProperty "storm.home")
- release-path (format "%s/RELEASE" storm-home)
- release-file (File. release-path)]
- (if (and (.exists release-file) (.isFile release-file))
- (trim (slurp release-path))
- "Unknown")))
+ (str VersionInfo/getVersion))
--- End diff --
This is not valid clojure. It should probably be something like
```(str (VersionInfo/getVersion))```
you are also going to have to explicitly import VersionInfo info core.clj.
> Record version and revision information in builds
> --------------------------------------------------
>
> Key: STORM-243
> URL: https://issues.apache.org/jira/browse/STORM-243
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: caofangkun
> Assignee: caofangkun
> Priority: Minor
> Attachments: STORM-243-1.patch
>
>
> Patch atteThe effect shown below,
> $ storm version
> Storm 0.9.2-incubating-SNAPSHOT
> Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959
> Compiled by somebody on Wed Feb 19 11:23:38 CST 2014
> From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f
> or
> $ java -classpath storm-core-0.9.2-incubating-SNAPSHOT.jar
> backtype.storm.utils.VersionInfo
> Storm 0.9.2-incubating-SNAPSHOT
> Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959
> Compiled by somebody on Wed Feb 19 11:23:38 CST 2014
> From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
