[
https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257328#comment-14257328
]
ASF GitHub Bot commented on STORM-243:
--------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/294#discussion_r22228250
--- Diff: storm-core/src/saveVersion.sh ---
@@ -0,0 +1,42 @@
+s file is used to generate the package-info.java class that
+# records the version, revision, branch, user, timestamp, and url
+unset LANG
+unset LC_CTYPE
+unset LC_TIME
+version=$1
+build_dir=$2
+user=`whoami`
+date=`date`
+cwd=`pwd`
+if [ -d .git ]; then
--- End diff --
This does not work with how the code is run from maven. The working
directory, at least for me, seems to be storm-core, so it never finds .git and
is not able to detect that the code is in git. subversion should not have the
same issues.
> Record version and revision information in builds
> --------------------------------------------------
>
> Key: STORM-243
> URL: https://issues.apache.org/jira/browse/STORM-243
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: caofangkun
> Assignee: caofangkun
> Priority: Minor
> Attachments: STORM-243-1.patch
>
>
> Patch atteThe effect shown below,
> $ storm version
> Storm 0.9.2-incubating-SNAPSHOT
> Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959
> Compiled by somebody on Wed Feb 19 11:23:38 CST 2014
> From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f
> or
> $ java -classpath storm-core-0.9.2-incubating-SNAPSHOT.jar
> backtype.storm.utils.VersionInfo
> Storm 0.9.2-incubating-SNAPSHOT
> Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959
> Compiled by somebody on Wed Feb 19 11:23:38 CST 2014
> From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
