Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/361#discussion_r22435341
--- Diff:
external/storm-kafka/src/jvm/storm/kafka/DynamicBrokersReader.java ---
@@ -41,6 +41,14 @@
private String _topic;
public DynamicBrokersReader(Map conf, String zkStr, String zkPath,
String topic) {
+ // Check required parameters
+ if(conf == null) {LOG.error("conf cannot be null");}
--- End diff --
Instead putting it in DynamicBrokersReader it will be better if we have
this in KafkaConfig and SpoutConfig and have a validate method there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
