Github user curtisallen commented on a diff in the pull request:
https://github.com/apache/storm/pull/361#discussion_r22474024
--- Diff:
external/storm-kafka/src/jvm/storm/kafka/DynamicBrokersReader.java ---
@@ -149,4 +158,19 @@ private Broker getBrokerHost(byte[] contents) {
}
}
+ private void validateConfig(final Map conf) {
+ if(conf.get(Config.STORM_ZOOKEEPER_SESSION_TIMEOUT) == null) {
--- End diff --
@harshach there are no defaults for these values, hence the reason for this
pull request. The constructor for the DynamicBrokerReader accepts a
`java.util.Map` Which must contain the values that are verified in this
`validateConfig` method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
