Github user curtisallen commented on a diff in the pull request:
https://github.com/apache/storm/pull/361#discussion_r22474338
--- Diff:
external/storm-kafka/src/jvm/storm/kafka/DynamicBrokersReader.java ---
@@ -41,6 +41,14 @@
private String _topic;
public DynamicBrokersReader(Map conf, String zkStr, String zkPath,
String topic) {
+ // Check required parameters
+ if(conf == null) {LOG.error("conf cannot be null");}
--- End diff --
@harshach Agreed. I didn't take that approach because it would require
significantly more changes to the spout since `DynamicBrokerReader` doesn't
reference `KafkaConfig` or `SpoutConfig` currently. Also it would require a
modification to `DynamicBrokerReader`'s constructor to accept a `KafkaConfig`
instance breaking legacy code. I thought that would be a big change for a minor
storm release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
