Github user miguno commented on a diff in the pull request:

    https://github.com/apache/storm/pull/268#discussion_r24039811
  
    --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java ---
    @@ -142,6 +147,15 @@ public void run() {
                     
                 }
             };
    +
    +        connector = new Runnable() {
    +            @Override
    +            public void run() {
    +                if (!closing) {
    +                    connect();
    +                }
    +            }
    +        };
             
             long initialDelay = Math.min(30L * 1000, max_sleep_ms * 
max_retries); //max wait for 30s
    --- End diff --
    
    Either the comment or the code are incorrect.
    
    If we want to wait a maximum of 30s, then we should use `Math.max(...)`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to