Github user MaximeDiab commented on a diff in the pull request:
https://github.com/apache/storm/pull/268#discussion_r24071792
--- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java ---
@@ -142,6 +147,15 @@ public void run() {
}
};
+
+ connector = new Runnable() {
+ @Override
+ public void run() {
+ if (!closing) {
+ connect();
+ }
+ }
+ };
long initialDelay = Math.min(30L * 1000, max_sleep_ms *
max_retries); //max wait for 30s
--- End diff --
we should use Math.max(...)?
No, I do not think so. because .max returns the argument with the greatest
value.
So Math.min (30L * 1000 * max_sleep_ms max_retries) will return 30 seconds
if "max_sleep_ms * max_retries" is greater than 30 s! and vice versa
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
