[ 
https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379600#comment-14379600
 ] 

Jungtaek Lim commented on STORM-723:
------------------------------------

Other way, we can document expiration feature to 'applied to key, so if you 
store your datas into container data type, you lose all of elements in key'.
I'm not 100% sure that explanation makes us innocent, but it will work, and we 
can support both various data types and expiration feature at same time.

[~dashengju] [~revans2] How about this? Do you feel uncomfortable or 
inconvenience?

> [storm-redis] RedisStateSetUpdater writes state into String but calls Set 
> operation
> -----------------------------------------------------------------------------------
>
>                 Key: STORM-723
>                 URL: https://issues.apache.org/jira/browse/STORM-723
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 0.10.0
>            Reporter: Jungtaek Lim
>            Assignee: Jungtaek Lim
>
> RedisStateSetUpdater writes value into String type, but it tries to retrieve 
> Set's element count from String type which will throw JedisDataException. 
> {code}
>                 if (this.expireIntervalSec > 0) {
>                     jedis.setex(redisKey, expireIntervalSec, value);
>                 } else {
>                     jedis.set(redisKey, value);
>                 }
>                 Long count = jedis.scard(redisKey);
> {code}
> Btw, Redis expire only applies to key, so above implementation seems to be 
> invalid.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to