[
https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381221#comment-14381221
]
DashengJu commented on STORM-723:
---------------------------------
Besides document expiration feature, shall we change Updater interface?
For example,
public RedisStateUpdater(String redisKeyPrefix, TupleMapper tupleMapper, int
expireIntervalSec);
we can change to :
public RedisStateUpdater(String redisKeyPrefix, TupleMapper tupleMapper);
public setKeyExpireInterval(int keyExpireIntervalSec);
we ask the user to set expire on key explicitly.
> [storm-redis] RedisStateSetUpdater writes state into String but calls Set
> operation
> -----------------------------------------------------------------------------------
>
> Key: STORM-723
> URL: https://issues.apache.org/jira/browse/STORM-723
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.10.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> RedisStateSetUpdater writes value into String type, but it tries to retrieve
> Set's element count from String type which will throw JedisDataException.
> {code}
> if (this.expireIntervalSec > 0) {
> jedis.setex(redisKey, expireIntervalSec, value);
> } else {
> jedis.set(redisKey, value);
> }
> Long count = jedis.scard(redisKey);
> {code}
> Btw, Redis expire only applies to key, so above implementation seems to be
> invalid.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
