[
https://issues.apache.org/jira/browse/STORM-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381626#comment-14381626
]
Jungtaek Lim commented on STORM-723:
------------------------------------
I reviewed RedisStateUpdater and RedisStateQuerier, and wish to discuss below.
How about having 2 mappers which one is for converting tuple to key/value, and
another one is for converting value from Redis to Storm Values?
Seems like key prefix is less powerful.
You can refer
https://github.com/apache/storm/blob/master/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/state/HBaseState.java
to understand what I'm saying.
> [storm-redis] RedisStateSetUpdater writes state into String but calls Set
> operation
> -----------------------------------------------------------------------------------
>
> Key: STORM-723
> URL: https://issues.apache.org/jira/browse/STORM-723
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.10.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> RedisStateSetUpdater writes value into String type, but it tries to retrieve
> Set's element count from String type which will throw JedisDataException.
> {code}
> if (this.expireIntervalSec > 0) {
> jedis.setex(redisKey, expireIntervalSec, value);
> } else {
> jedis.set(redisKey, value);
> }
> Long count = jedis.scard(redisKey);
> {code}
> Btw, Redis expire only applies to key, so above implementation seems to be
> invalid.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
