[
https://issues.apache.org/jira/browse/STORM-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510535#comment-14510535
]
ASF GitHub Bot commented on STORM-436:
--------------------------------------
GitHub user danielcompton opened a pull request:
https://github.com/apache/storm/pull/534
[STORM-436] Clean up ns declarations
This is a WIP, I'm wanting to get feedback on the style before going too
far.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/danielcompton/storm clean-up-ns
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/534.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #534
----
commit 912eea4ff02818ef319b3897ba892ea5cd529c2a
Author: Daniel Compton <[email protected]>
Date: 2015-04-24T06:27:08Z
[STORM-436] Clean up ns declarations
----
> Clean up Clojure namespace declarations
> ---------------------------------------
>
> Key: STORM-436
> URL: https://issues.apache.org/jira/browse/STORM-436
> Project: Apache Storm
> Issue Type: Improvement
> Affects Versions: 0.9.2-incubating
> Reporter: Daniel Compton
> Priority: Minor
> Labels: newbie
>
> Some of the Clojure namespace declarations in the storm project are messy and
> non-idiomatic.
> https://github.com/apache/incubator-storm/blob/master/storm-core/src/clj/backtype/storm/ui/core.clj#L18-L38
> is a good example of this.
> There are a few things I'd like to improve:
> 1. Coalesce multiple use/require/import's into a single use/require/import.
> 2. Order imports use, require, import.
> 3. Optionally, replacing use with some mix of
> * [... :refer :all]
> * Referring just the vars that are used
> * Qualifying the namespace imports
> Is there a reason why the namespaces were done in the way they have been?
> What would be the preferred way to do 3?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)