[ 
https://issues.apache.org/jira/browse/STORM-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14519744#comment-14519744
 ] 

ASF GitHub Bot commented on STORM-436:
--------------------------------------

Github user knusbaum commented on a diff in the pull request:

    https://github.com/apache/storm/pull/534#discussion_r29357225
  
    --- Diff: storm-core/src/clj/backtype/storm/config.clj ---
    @@ -20,7 +20,8 @@
       (:import [backtype.storm Config ConfigValidation$FieldValidator])
       (:import [backtype.storm.utils Utils LocalState])
       (:import [org.apache.commons.io FileUtils])
    -  (:require [clojure [string :as str]])
    +  (:require [clojure.string :as str]
    +            [backtype.storm.util :as util])
       (:use [backtype.storm log util]))
    --- End diff --
    
    Leftover `(:use [... util])`


> Clean up Clojure namespace declarations
> ---------------------------------------
>
>                 Key: STORM-436
>                 URL: https://issues.apache.org/jira/browse/STORM-436
>             Project: Apache Storm
>          Issue Type: Improvement
>    Affects Versions: 0.9.2-incubating
>            Reporter: Daniel Compton
>            Priority: Minor
>              Labels: newbie
>
> Some of the Clojure namespace declarations in the storm project are messy and 
> non-idiomatic. 
> https://github.com/apache/incubator-storm/blob/master/storm-core/src/clj/backtype/storm/ui/core.clj#L18-L38
>  is a good example of this.
> There are a few things I'd like to improve:
> 1. Coalesce multiple use/require/import's into a single use/require/import.
> 2. Order imports use, require, import.
> 3. Optionally, replacing use with some mix of
>     * [... :refer :all]
>     * Referring just the vars that are used
>     * Qualifying the namespace imports
> Is there a reason why the namespaces were done in the way they have been? 
> What would be the preferred way to do 3?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to