[ 
https://issues.apache.org/jira/browse/STORM-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14519987#comment-14519987
 ] 

ASF GitHub Bot commented on STORM-436:
--------------------------------------

Github user danielcompton commented on the pull request:

    https://github.com/apache/storm/pull/534#issuecomment-97548295
  
    My plan is to get rid of all of the :uses by the time I've finished this 
patch. There are some spots where I've left :uses because I haven't finished 
refactoring those namespaces. There's also a few aliasing and :refering 
inconsistencies between my earlier work and the later namespaces which I need 
to go back and fix.
    
    A namespace style policy would be good too, would that go in DEVELOPERS.md?
    
    As I work on this, is it going to be easier for me to keep squashing my 
changes into the same commit, or wait until its finished and squash them before 
merging?


> Clean up Clojure namespace declarations
> ---------------------------------------
>
>                 Key: STORM-436
>                 URL: https://issues.apache.org/jira/browse/STORM-436
>             Project: Apache Storm
>          Issue Type: Improvement
>    Affects Versions: 0.9.2-incubating
>            Reporter: Daniel Compton
>            Priority: Minor
>              Labels: newbie
>
> Some of the Clojure namespace declarations in the storm project are messy and 
> non-idiomatic. 
> https://github.com/apache/incubator-storm/blob/master/storm-core/src/clj/backtype/storm/ui/core.clj#L18-L38
>  is a good example of this.
> There are a few things I'd like to improve:
> 1. Coalesce multiple use/require/import's into a single use/require/import.
> 2. Order imports use, require, import.
> 3. Optionally, replacing use with some mix of
>     * [... :refer :all]
>     * Referring just the vars that are used
>     * Qualifying the namespace imports
> Is there a reason why the namespaces were done in the way they have been? 
> What would be the preferred way to do 3?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to