Github user knusbaum commented on a diff in the pull request:

    https://github.com/apache/storm/pull/534#discussion_r29352390
  
    --- Diff: storm-core/src/clj/backtype/storm/command/dev_zookeeper.clj ---
    @@ -14,13 +14,15 @@
     ;; See the License for the specific language governing permissions and
     ;; limitations under the License.
     (ns backtype.storm.command.dev-zookeeper
    -  (:use [backtype.storm zookeeper util config])
    +  (:require [backtype.storm.zookeeper :as zoo]
    +            [backtype.storm.config :as config])
    +  (:use [backtype.storm util ])
    --- End diff --
    
    Trailing space after util.
    
    Is there a reason we're keeping util in a use form instead of putting it in 
a require, unlike the others?
    
    The second item in the jira is:
    '2. Order imports use, require, import.'
    but here you've put the use after the require.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to