Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/534#discussion_r29353105
--- Diff: storm-core/src/clj/backtype/storm/command/rebalance.clj ---
@@ -14,19 +14,20 @@
;; See the License for the specific language governing permissions and
;; limitations under the License.
(ns backtype.storm.command.rebalance
- (:use [clojure.tools.cli :only [cli]])
- (:use [backtype.storm thrift config log])
+ (:require [clojure.tools.cli :refer [cli]]
+ [backtype.storm.thrift :as thrift]
+ [backtype.storm.log :as log])
(:import [backtype.storm.generated RebalanceOptions])
(:gen-class))
+;; TODO: do we need all these gen-class's?
--- End diff --
For the commands, yes. These are the classes launched by bin/storm.
If you find other `:gen-class` instances you think we can get rid of, feel
free to point them out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---