Github user knusbaum commented on the pull request:

    https://github.com/apache/storm/pull/534#issuecomment-97513417
  
    I'm generally in favor of this. It's something that's bugged me for a 
while. 
    I did a preliminary review on a portion of the changes. Mostly just some 
minor spacing and stuff.
    
    One thing I'd like is to get rid of `:use` completely, if we're going to 
refactor the ns forms. Clojure devs discourage its use in favor of `(:require 
whatever.namespace :refer :all)`.
    
    More consistency with which namespaces we're requiring `:as` something and 
which ones we're importing wholesale with `:use` or `:refer :all` would be 
nice. I see sometimes you `:require` `backtype.storm.util` and sometimes you 
leave it in a `:use` They don't all have to be one way or the other, but I get 
the sense that the ones you've chosen to change were chosen arbitrarily (Or 
maybe just accidentally skipped over; there's a lot to change).
    
    We should probably also put a namespace style policy in writing, just to 
make it easy for others to follow.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to