[jira] [Commented] (STORM-826) As a storm developer I’d like to use the new kafka producer API to reduce dependencies and use long term supported kafka apis

Tue, 16 Jun 2015 11:18:13 -0700 

    [ 
https://issues.apache.org/jira/browse/STORM-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14588499#comment-14588499
 ] 

ASF GitHub Bot commented on STORM-826:
--------------------------------------

Github user d2r commented on a diff in the pull request:

    https://github.com/apache/storm/pull/572#discussion_r32552545
  
    --- Diff: external/storm-kafka/src/test/storm/kafka/KafkaUtilsTest.java ---
    @@ -168,7 +168,7 @@ public void 
generateTuplesWithValueSchemeAndKeyValueMessage() {
         }
     
         private ByteBufferMessageSet getLastMessage() {
    -        long offsetOfLastMessage = KafkaUtils.getOffset(simpleConsumer, 
config.topic, 0, OffsetRequest.LatestTime()) - 1;
    +        long offsetOfLastMessage = KafkaUtils.getOffset(simpleConsumer, 
config.topic, 0, OffsetRequest.LatestTime());
    --- End diff --
    
    This change seems a little odd to me.  Do we know why the tests off-by-one 
after this change?


> As a storm developer I’d like to use the new kafka producer API to reduce 
> dependencies and use long term supported kafka apis 
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: STORM-826
>                 URL: https://issues.apache.org/jira/browse/STORM-826
>             Project: Apache Storm
>          Issue Type: Story
>          Components: storm-kafka
>            Reporter: Thomas Becker
>            Assignee: Zhuo Liu
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to