[jira] [Commented] (STORM-826) As a storm developer I’d like to use the new kafka producer API to reduce dependencies and use long term supported kafka apis

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/STORM-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14588751#comment-14588751
 ] 

ASF GitHub Bot commented on STORM-826:
--------------------------------------

Github user zhuoliu commented on a diff in the pull request:

    https://github.com/apache/storm/pull/572#discussion_r32569256
  
    --- Diff: external/storm-kafka/src/test/storm/kafka/KafkaUtilsTest.java ---
    @@ -168,7 +168,7 @@ public void 
generateTuplesWithValueSchemeAndKeyValueMessage() {
         }
     
         private ByteBufferMessageSet getLastMessage() {
    -        long offsetOfLastMessage = KafkaUtils.getOffset(simpleConsumer, 
config.topic, 0, OffsetRequest.LatestTime()) - 1;
    +        long offsetOfLastMessage = KafkaUtils.getOffset(simpleConsumer, 
config.topic, 0, OffsetRequest.LatestTime());
    --- End diff --
    
    To address this concern, I just updated the producer in KafkaUtilsTest with 
new kafka Producer API, and use "send().get()" to do synchronous sending. Then 
the offset uncertainty can be fixed and we no longer need to change that offset 
line in the test.


> As a storm developer I’d like to use the new kafka producer API to reduce 
> dependencies and use long term supported kafka apis 
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: STORM-826
>                 URL: https://issues.apache.org/jira/browse/STORM-826
>             Project: Apache Storm
>          Issue Type: Story
>          Components: storm-kafka
>            Reporter: Thomas Becker
>            Assignee: Zhuo Liu
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)