[
https://issues.apache.org/jira/browse/STORM-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608387#comment-14608387
]
Aaron Dossett commented on STORM-799:
-------------------------------------
I agree with the first suggestion of using the IErrorReporter interface more
broadly. While making that change I found a run-time cast in
MetricsConsumerBolt that can be removed, making the code more type safe. I
will submit a PR for this shortly.
Changing the public API on IBasicBolt seems like a substantial change. I'm too
new to Storm to assess the wisdom of that.
> Consolidate IErrorReporter and reportError methods
> --------------------------------------------------
>
> Key: STORM-799
> URL: https://issues.apache.org/jira/browse/STORM-799
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Simon Cooper
> Priority: Minor
>
> ISpoutOutputCollector and IBasicOutputCollector all have a
> reportError(Throwable) method. This is identical to the method on
> IErrorReporter (which IBasicErrorReporter extends)
> It would help shared library code if all three collector types extended
> IErrorReporter, so that the same error-handling code can be used with all
> three component types.
> Additionally, it would be good if IBasicBolt passed an IErrorReporter in its
> prepare method, so the bolt can report errors during preparation, not just in
> tuple processing, and to ease interop between IRichBolt and IRichSpout which
> both have access to an error-reporting object during preparation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
