[
https://issues.apache.org/jira/browse/STORM-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629944#comment-14629944
]
ASF GitHub Bot commented on STORM-799:
--------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/607#issuecomment-122006252
+1. The only possible issue is if someone is implementing their own
OutputCollector, possibly for running storm topologies on a different runtime.
And I am not too concerned about breaking them.
> Consolidate IErrorReporter and reportError methods
> --------------------------------------------------
>
> Key: STORM-799
> URL: https://issues.apache.org/jira/browse/STORM-799
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Simon Cooper
> Assignee: Aaron Dossett
> Priority: Minor
>
> ISpoutOutputCollector and IBasicOutputCollector all have a
> reportError(Throwable) method. This is identical to the method on
> IErrorReporter (which IBasicErrorReporter extends)
> It would help shared library code if all three collector types extended
> IErrorReporter, so that the same error-handling code can be used with all
> three component types.
> Additionally, it would be good if IBasicBolt passed an IErrorReporter in its
> prepare method, so the bolt can report errors during preparation, not just in
> tuple processing, and to ease interop between IRichBolt and IRichSpout which
> both have access to an error-reporting object during preparation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
