[
https://issues.apache.org/jira/browse/STORM-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608388#comment-14608388
]
ASF GitHub Bot commented on STORM-799:
--------------------------------------
GitHub user dossett opened a pull request:
https://github.com/apache/storm/pull/607
STORM-799 Use IErrorReport interface more broadly
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dossett/storm STORM-799
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/607.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #607
----
commit 735fae7899eb8240b7a0d5514c6f68a9f6be3e4f
Author: Aaron Dossett <[email protected]>
Date: 2015-06-30T14:29:32Z
STORM-799 Use IErrorReport interface more broadly
----
> Consolidate IErrorReporter and reportError methods
> --------------------------------------------------
>
> Key: STORM-799
> URL: https://issues.apache.org/jira/browse/STORM-799
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Simon Cooper
> Priority: Minor
>
> ISpoutOutputCollector and IBasicOutputCollector all have a
> reportError(Throwable) method. This is identical to the method on
> IErrorReporter (which IBasicErrorReporter extends)
> It would help shared library code if all three collector types extended
> IErrorReporter, so that the same error-handling code can be used with all
> three component types.
> Additionally, it would be good if IBasicBolt passed an IErrorReporter in its
> prepare method, so the bolt can report errors during preparation, not just in
> tuple processing, and to ease interop between IRichBolt and IRichSpout which
> both have access to an error-reporting object during preparation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
