Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/700#discussion_r38021586
--- Diff: storm-core/src/clj/backtype/storm/daemon/executor.clj ---
@@ -602,7 +607,15 @@
(log-message "Activating spout " component-id ":"
(keys task-datas))
(fast-list-iter [^ISpout spout spouts] (.activate
spout)))
- (fast-list-iter [^ISpout spout spouts] (.nextTuple
spout)))
+ (if (and
+ ((:storm-conf executor-data)
TOPOLOGY-BACKPRESSURE-ENABLE)
+ @(:throttle-on (:worker executor-data))
+ suspend-time
+ (not= suspend-time 0))
+ (do
--- End diff --
Can we move this conditional up to be part of the
overflow-buffer/max-spout-pending check? It feels like it fits better there,
and that we don't want to output anything when back-pressure is on, instead of
just slowing down how quickly we output.
Also instead of logging something, can we look at having a metric instead
that shows how may times we called paused for a given reason. Logging is not
going to really give us the picture we want and is going to be difficult to
follow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
