Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/700#discussion_r38022111
--- Diff: storm-core/src/clj/backtype/storm/daemon/executor.clj ---
@@ -671,7 +689,19 @@
user-context (:user-context task-data)
sampler? (sampler)
execute-sampler? (execute-sampler)
- now (if (or sampler? execute-sampler?)
(System/currentTimeMillis))]
+ now (if (or sampler? execute-sampler?)
(System/currentTimeMillis))
+ receive-queue (:receive-queue
executor-data)]
+ (if (and ((:storm-conf executor-data)
TOPOLOGY-BACKPRESSURE-ENABLE)
+ (> (.population receive-queue)
high-watermark)
+ (not @(:backpressure
executor-data)))
+ (do (reset! (:backpressure
executor-data) true)
+ (log-debug "executor " (:executor-id
executor-data) " is congested, set backpressure flag true")
+
(disruptor/notify-backpressure-checker (:backpressure-trigger (:worker
executor-data)))))
+ (if (and ((:storm-conf executor-data)
TOPOLOGY-BACKPRESSURE-ENABLE)
+ (< (.population receive-queue)
low-watermark)
+ @(:backpressure executor-data))
+ (do (reset! (:backpressure
executor-data) false)
+
(disruptor/notify-backpressure-checker (:backpressure-trigger (:worker
executor-data)))))
--- End diff --
I am a bit confused. Why are we doing this as part of the metrics tick?
What does that have to do with back pressure at all?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
