Github user mjsax commented on a diff in the pull request:
https://github.com/apache/storm/pull/740#discussion_r39935812
--- Diff: storm-core/test/clj/backtype/storm/nimbus_test.clj ---
@@ -846,16 +846,6 @@
NIMBUS-SLOTS-PER-TOPOLOGY 8}]
(letlocals
(bind topology (thrift/mk-topology
- {"1" (thrift/mk-spout-spec (TestPlannerSpout.
true) :parallelism-hint 0 :conf {TOPOLOGY-TASKS 1})}
--- End diff --
Removed this test because it now throws different exception and this is
tested in the new unit test I added for `TopologyBuilder`. Actually, I tried to
change the expected exception, but this did not fix this test for me (the test
fails if I change `InvalidTopologyException` to `IllegalArgumentException`).
Don't know why. But I am still new to Clojure and Clojure tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
