Github user mjsax commented on a diff in the pull request:
https://github.com/apache/storm/pull/740#discussion_r39936186
--- Diff: storm-core/test/clj/backtype/storm/nimbus_test.clj ---
@@ -846,16 +846,6 @@
NIMBUS-SLOTS-PER-TOPOLOGY 8}]
(letlocals
(bind topology (thrift/mk-topology
- {"1" (thrift/mk-spout-spec (TestPlannerSpout.
true) :parallelism-hint 0 :conf {TOPOLOGY-TASKS 1})}
--- End diff --
I agree on this.
However, I still don't understand why changing the expected exception type
does not "fix" the test... If I put `thrown? IllegalArgumentException` instead
of `thrown? InvalidTopologyException` the test does not pass but fails. Can you
explain?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
