Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/740#discussion_r39936239
--- Diff: storm-core/test/clj/backtype/storm/nimbus_test.clj ---
@@ -846,16 +846,6 @@
NIMBUS-SLOTS-PER-TOPOLOGY 8}]
(letlocals
(bind topology (thrift/mk-topology
- {"1" (thrift/mk-spout-spec (TestPlannerSpout.
true) :parallelism-hint 0 :conf {TOPOLOGY-TASKS 1})}
--- End diff --
Because thrift/mk-topology actually throws IllegalArgumentException, not
submit-local-topology.
We should wrap bind statement to check IllegalArgumentException.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
