Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r43781137
--- Diff: storm-core/src/clj/backtype/storm/cluster.clj ---
@@ -593,18 +612,22 @@
(let [thrift-assignment (thriftify-assignment info)]
(set-data cluster-state (assignment-path storm-id)
(Utils/serialize thrift-assignment) acls)))
- (setup-code-distributor!
- [this storm-id nimbusInfo]
- (let [path (str (code-distributor-path storm-id) "/"
(.toHostPortString nimbusInfo))]
- (mkdirs cluster-state (code-distributor-path storm-id) acls)
- ;we delete the node first to ensure the node gets created as part
of this session only.
- (delete-node cluster-state path)
- (set-ephemeral-node cluster-state path nil acls)))
+ (setup-blobstore!
+ [this key nimbusInfo versionInfo]
+ (let [path (str (blobstore-path key) "/" (.toHostPortString
nimbusInfo) "-" versionInfo)]
+ (mkdirs cluster-state (blobstore-path key) acls)
+ ;we delete the node first to ensure the node gets created as
part of this session only.
+ (delete-node-blobstore cluster-state (str (blobstore-path key))
(.toHostPortString nimbusInfo))
+ (set-ephemeral-node cluster-state path nil acls)))
+
+ (remove-blobstore-key!
+ [this blob-key]
+ (log-debug "removing key" blob-key)
+ (delete-node cluster-state (blobstore-path blob-key)))
(remove-storm!
[this storm-id]
(delete-node cluster-state (assignment-path storm-id))
- (delete-node cluster-state (code-distributor-path storm-id))
--- End diff --
(schedule-recurring (:timer nimbus)
0
(conf NIMBUS-MONITOR-FREQ-SECS)
(fn []
(when-not (conf NIMBUS-DO-NOT-REASSIGN)
(locking (:submit-lock nimbus)
(mk-assignments nimbus)))
(do-cleanup nimbus) --> The clean up code takes
care of deleting the blobs
))
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
