Github user knusbaum commented on a diff in the pull request:

    https://github.com/apache/storm/pull/845#discussion_r43787675
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj ---
    @@ -346,53 +394,124 @@
           [(.getNodeId slot) (.getPort slot)]
           )))
     
    +(defn- get-nimbus-subject []
    +  (let [nimbus-subject (Subject.)
    +        nimbus-principal (NimbusPrincipal.)
    +        principals (.getPrincipals nimbus-subject)]
    +    (.add principals nimbus-principal)
    +    nimbus-subject))
    +
    +(defn- get-metadata-version [blob-store key subject]
    +  (let [blob-meta (.getBlobMeta blob-store key subject)]
    +    (.get_version blob-meta)))
    +
    +(defn get-key-list-from-blob-store [blob-store]
    +  (let [key-iter (.listKeys blob-store (get-nimbus-subject))
    +        keys (iterator-seq key-iter)]
    +    (if (not-nil? keys)
    +      (java.util.ArrayList. keys)
    +      [])))
    --- End diff --
    
    Here in one place you're returning a java ArrayList, and in the other 
you're returning a clojure vector.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to