Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/845#discussion_r43785974
--- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj ---
@@ -950,20 +1074,33 @@
TOPOLOGY-EVENTLOGGER-EXECUTORS (total-conf
TOPOLOGY-EVENTLOGGER-EXECUTORS)
TOPOLOGY-MAX-TASK-PARALLELISM (total-conf
TOPOLOGY-MAX-TASK-PARALLELISM)})))
+(defn blob-rm [blob-store key storm-cluster-state]
+ (try
+ (.deleteBlob blob-store key (get-nimbus-subject))
+ (if (instance? LocalFsBlobStore blob-store)
+ (.remove-blobstore-key! storm-cluster-state key))
+ (catch Exception e)))
+
+(defn rm-from-blob-store [id blob-store storm-cluster-state]
--- End diff --
Could we rename these? blob-rm and rm-from-blob-store don't differentiate
each other. I think it would be better to be something like `blob-rm-key` and
`blob-rm-topology-keys`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
