[
https://issues.apache.org/jira/browse/STORM-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15042386#comment-15042386
]
ASF GitHub Bot commented on STORM-1374:
---------------------------------------
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/925
STORM-1374 fix random failure on WindowManagerTest
* Problem: Trigger could be called two times while sleeping
* which first one has the events which are actually we want
* and second one resets it, which makes test failed
* Solution: Trigger manually
* and remove sleep if not necessary
@arunmahadevan Please verify this shouldn't break your intention on
WindowManagerTest.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-1374
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/925.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #925
----
commit 98c90f0fa583e2932c2c8639e9ec483915c47ff1
Author: Jungtaek Lim <[email protected]>
Date: 2015-12-04T23:03:22Z
STORM-1374 fix random failure on WindowManagerTest
* Problem: Trigger could be called two times while sleeping
* which first one has the events which are actually we want
* and second one resets it, which makes test failed
* Solution: Trigger manually
* and remove sleep if not necessary
----
> Random test failures on WindowManagerTest
> -----------------------------------------
>
> Key: STORM-1374
> URL: https://issues.apache.org/jira/browse/STORM-1374
> Project: Apache Storm
> Issue Type: Sub-task
> Components: storm-core
> Reporter: Jungtaek Lim
> Priority: Minor
>
> https://travis-ci.org/apache/storm/jobs/94768693
> {code}
> testTimeBasedWindow(backtype.storm.windowing.WindowManagerTest) Time
> elapsed: 0.176 sec <<< FAILURE!
> java.lang.AssertionError: expected:<100> but was:<0>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:555)
> at org.junit.Assert.assertEquals(Assert.java:542)
> at
> backtype.storm.windowing.WindowManagerTest.testTimeBasedWindow(WindowManagerTest.java:163)
> testTimeBasedWindowExpiry(backtype.storm.windowing.WindowManagerTest) Time
> elapsed: 0.16 sec <<< FAILURE!
> java.lang.AssertionError: expected:<[1, 2, 3, 4, 5, 6, 7, 8, 9, 10]> but
> was:<[]>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at
> backtype.storm.windowing.WindowManagerTest.testTimeBasedWindowExpiry(WindowManagerTest.java:199)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
