[
https://issues.apache.org/jira/browse/STORM-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044090#comment-15044090
]
ASF GitHub Bot commented on STORM-1374:
---------------------------------------
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/925#issuecomment-162341005
@HeartSaVioR so I think it will cause trigger to fire two times (during
sleep and then manually). For the current test cases it does not matter so your
patch would work.
I updated the unit tests as a part of PR#900 to not rely on sleep and
trigger manually.
https://github.com/apache/storm/pull/900/files#diff-04ed7847355c5e160efb25a9a5dc8a25R157
> Random test failures on WindowManagerTest
> -----------------------------------------
>
> Key: STORM-1374
> URL: https://issues.apache.org/jira/browse/STORM-1374
> Project: Apache Storm
> Issue Type: Sub-task
> Components: storm-core
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
> Priority: Minor
>
> https://travis-ci.org/apache/storm/jobs/94768693
> {code}
> testTimeBasedWindow(backtype.storm.windowing.WindowManagerTest) Time
> elapsed: 0.176 sec <<< FAILURE!
> java.lang.AssertionError: expected:<100> but was:<0>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:555)
> at org.junit.Assert.assertEquals(Assert.java:542)
> at
> backtype.storm.windowing.WindowManagerTest.testTimeBasedWindow(WindowManagerTest.java:163)
> testTimeBasedWindowExpiry(backtype.storm.windowing.WindowManagerTest) Time
> elapsed: 0.16 sec <<< FAILURE!
> java.lang.AssertionError: expected:<[1, 2, 3, 4, 5, 6, 7, 8, 9, 10]> but
> was:<[]>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at
> backtype.storm.windowing.WindowManagerTest.testTimeBasedWindowExpiry(WindowManagerTest.java:199)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
