[
https://issues.apache.org/jira/browse/STORM-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15045871#comment-15045871
]
ASF GitHub Bot commented on STORM-1348:
---------------------------------------
GitHub user fhussonnois opened a pull request:
https://github.com/apache/storm/pull/929
STORM-1348 - refactor API to remove Insert/Update builder in Cassandra
connector
I need to add some tests but I open this PR to start its review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhussonnois/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/929.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #929
----
commit 8eca74586ac852b89614f97ce5cd9429af7e7286
Author: Florian Hussonnois <[email protected]>
Date: 2015-12-06T21:23:29Z
STORM-1348 - refactor API to remove Insert/Update builder in Cassandra
connector
----
> Refactor API to remove Insert/Update builder in Cassandra connector
> -------------------------------------------------------------------
>
> Key: STORM-1348
> URL: https://issues.apache.org/jira/browse/STORM-1348
> Project: Apache Storm
> Issue Type: Bug
> Environment: @fhussonnois I think we should accept only cql strings
> for now instead of giving a fluent API for building queries. This requires
> implementing all kinds of queries supported by cql just to map column names
> which is kind of unnecessary. Cassandra connector API should be agnostic
> about the cql by simply using datastax driver. This avoids implementing any
> new features being added in cql by cassandra connector APIs. We should
> support only simple/prepared/batched statement builder by giving respective
> API to map columns with tuples.
> https://github.com/apache/storm/pull/827#issuecomment-158807186
> @satishd, @harshach ok perfect. So I will refactor API to remove
> Insert/Update builder.
> https://github.com/apache/storm/pull/827#issuecomment-159316692
> Reporter: Satish Duggana
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)