[
https://issues.apache.org/jira/browse/STORM-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15046357#comment-15046357
]
ASF GitHub Bot commented on STORM-1348:
---------------------------------------
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/929#discussion_r46915153
--- Diff:
external/storm-cassandra/src/test/java/org/apache/storm/cassandra/DynamicStatementBuilderTest.java
---
@@ -56,78 +61,93 @@
when(mockTuple.getFields()).thenReturn(new
Fields("weatherstation_id", "event_time", "temperature"));
}
+ public static final String QUERY_STRING = "INSERT INTO
weather.temperature(weatherstation_id,event_time,temperature) VALUES (?,?,?);";
+
--- End diff --
Change weatherstation_id to weather_station_id which is aligned with actual
name in the table mentioned in resources.
> Refactor API to remove Insert/Update builder in Cassandra connector
> -------------------------------------------------------------------
>
> Key: STORM-1348
> URL: https://issues.apache.org/jira/browse/STORM-1348
> Project: Apache Storm
> Issue Type: Bug
> Environment: @fhussonnois I think we should accept only cql strings
> for now instead of giving a fluent API for building queries. This requires
> implementing all kinds of queries supported by cql just to map column names
> which is kind of unnecessary. Cassandra connector API should be agnostic
> about the cql by simply using datastax driver. This avoids implementing any
> new features being added in cql by cassandra connector APIs. We should
> support only simple/prepared/batched statement builder by giving respective
> API to map columns with tuples.
> https://github.com/apache/storm/pull/827#issuecomment-158807186
> @satishd, @harshach ok perfect. So I will refactor API to remove
> Insert/Update builder.
> https://github.com/apache/storm/pull/827#issuecomment-159316692
> Reporter: Satish Duggana
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
