[
https://issues.apache.org/jira/browse/STORM-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15046348#comment-15046348
]
ASF GitHub Bot commented on STORM-1348:
---------------------------------------
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/929#discussion_r46915054
--- Diff:
external/storm-cassandra/src/main/java/org/apache/storm/cassandra/query/builder/BoundCQLStatementMapperBuilder.java
---
@@ -0,0 +1,104 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.storm.cassandra.query.builder;
+
+import org.apache.storm.cassandra.query.*;
+import org.apache.storm.cassandra.query.impl.BoundCQLStatementTupleMapper;
+import org.apache.storm.cassandra.query.impl.PreparedStatementBinder;
+import org.apache.storm.cassandra.query.impl.RoutingKeyGenerator;
+import org.apache.storm.cassandra.query.selector.FieldSelector;
+
+import java.io.Serializable;
+import java.util.*;
--- End diff --
Remove wild card imports.
> Refactor API to remove Insert/Update builder in Cassandra connector
> -------------------------------------------------------------------
>
> Key: STORM-1348
> URL: https://issues.apache.org/jira/browse/STORM-1348
> Project: Apache Storm
> Issue Type: Bug
> Environment: @fhussonnois I think we should accept only cql strings
> for now instead of giving a fluent API for building queries. This requires
> implementing all kinds of queries supported by cql just to map column names
> which is kind of unnecessary. Cassandra connector API should be agnostic
> about the cql by simply using datastax driver. This avoids implementing any
> new features being added in cql by cassandra connector APIs. We should
> support only simple/prepared/batched statement builder by giving respective
> API to map columns with tuples.
> https://github.com/apache/storm/pull/827#issuecomment-158807186
> @satishd, @harshach ok perfect. So I will refactor API to remove
> Insert/Update builder.
> https://github.com/apache/storm/pull/827#issuecomment-159316692
> Reporter: Satish Duggana
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
