Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47697722
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/RAS_Node.java ---
@@ -193,17 +199,21 @@ public void freeAllSlots(Cluster cluster) {
/**
* Frees a single slot in this node
* @param ws the slot to free
- * @param cluster the cluster to update
*/
- public void free(WorkerSlot ws, Cluster cluster) {
+ public void free(WorkerSlot ws) {
+ LOG.info("freeing ws {} on node {}", ws, _hostname);
--- End diff --
Can we call it 'slot' or something instead of 'ws' though. Until I read the
type of the argument, I didn't know what ws was. Seeing that in the logs might
be confusing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
