Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47698573
--- Diff:
storm-core/src/jvm/backtype/storm/scheduler/resource/RAS_Node.java ---
@@ -72,10 +71,9 @@ public RAS_Node(String nodeId, Set<Integer> allPorts,
boolean isAlive,
_availMemory = this.getTotalMemoryResources();
_availCPU = this.getTotalCpuResources();
_slots.addAll(_freeSlots);
- for (WorkerSlot ws : _slots) {
- _slotToExecs.put(ws, new ArrayList<ExecutorDetails>());
- }
}
+ this._cluster = cluster;
--- End diff --
Can we also not use `this` for member variables that have been tagged as
such by naming convention? That's exactly what the underscore is intended to
communicate. There's no benefit to using both.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
