Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/921#discussion_r47697865
--- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java
---
@@ -67,6 +73,12 @@ public TopologyDetails(String topologyId, Map
topologyConf, StormTopology topolo
this.initConfigs();
}
+ public TopologyDetails(String topologyId, Map topologyConf,
StormTopology topology,
+ int numWorkers, Map<ExecutorDetails, String>
executorToComponents, int launchTime) {
+ this(topologyId, topologyConf, topology, numWorkers,
executorToComponents);
+ this.launchTime = launchTime;
+ }
--- End diff --
It would be better to have the less specialized constructor call into the
more specialized constructor, instead of the other way around.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
