Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/977#discussion_r49160913
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java
---
@@ -131,6 +150,21 @@ private void failQueuedTuples(List<Tuple>
failedTuples) {
return queuedTuples;
}
+ @Override
+ public Map<String, Object> getComponentConfiguration() {
--- End diff --
@vesense I noticed that the body of this method is exactly the same for
AbstractHdfsBolt. Furthermore, it's very likely that many Storm connector bolts
will use the same code. Can you please write a helper method in TupleUtils and
call that method here and AbstractHdfsBolt.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
