Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/977#discussion_r49266446
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java
---
@@ -59,16 +63,29 @@ public SolrUpdateBolt(SolrConfig solrConfig, SolrMapper
solrMapper, SolrCommitSt
this.solrConfig = solrConfig;
this.solrMapper = solrMapper;
this.commitStgy = commitStgy;
- logger.debug("Created {} with the following configuration: " +
+ LOG.debug("Created {} with the following configuration: " +
"[SolrConfig = {}], [SolrMapper = {}], [CommitStgy =
{}]",
this.getClass().getSimpleName(), solrConfig,
solrMapper, commitStgy);
}
+ @Override
public void prepare(Map stormConf, TopologyContext context,
OutputCollector collector) {
this.collector = collector;
this.solrClient = new
CloudSolrClient(solrConfig.getZkHostString());
this.toCommitTuples = new ArrayList<>(capacity());
+ this.tickTupleInterval = solrConfig.getTickTupleInterval();
--- End diff --
@vesense I would suggest that all the code handling the tickTupleInterval
goes inside the method setTickTupleInterval. It is cleaner then setting the
field tickTupleInterval in prepare, and then have an if, and then set the field
again in setTickTupleInterval. The default case should be handled there as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
