Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/977#discussion_r49160962
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java
---
@@ -59,15 +63,24 @@ public SolrUpdateBolt(SolrConfig solrConfig, SolrMapper
solrMapper, SolrCommitSt
this.solrConfig = solrConfig;
this.solrMapper = solrMapper;
this.commitStgy = commitStgy;
- logger.debug("Created {} with the following configuration: " +
+ LOG.debug("Created {} with the following configuration: " +
"[SolrConfig = {}], [SolrMapper = {}], [CommitStgy =
{}]",
this.getClass().getSimpleName(), solrConfig,
solrMapper, commitStgy);
}
+ @Override
public void prepare(Map stormConf, TopologyContext context,
OutputCollector collector) {
this.collector = collector;
this.solrClient = new
CloudSolrClient(solrConfig.getZkHostString());
this.toCommitTuples = new ArrayList<>(capacity());
+ this.tickTupleInterval = solrConfig.getTickTupleInterval();
+
+ //set default tickTupleInterval
+ if (stormConf.containsKey("topology.message.timeout.secs") &&
tickTupleInterval == 0) {
--- End diff --
@vesense Please create a private method called something
setDefaultTickTupleInterval() with this code and call it here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
